Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2385] improvement(test): Make all tests in integration-common-test use random port #2387

Merged
merged 7 commits into from
Mar 12, 2025
Merged

[#2385] improvement(test): Make all tests in integration-common-test use random port #2387

merged 7 commits into from
Mar 12, 2025
+506 −844

Conversation

summaryzb
Copy link
Contributor

What changes were proposed in this pull request?

All tests in integration-test/common use random port

Why are the changes needed?

Fix: #2385

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

Test Results

 2 996 files  ±0   2 996 suites  ±0   6h 30m 57s ⏱️ -30s
 1 105 tests ±0   1 103 ✅ ±0   2 💤 ±0  0 ❌ ±0 
13 849 runs  ±0  13 819 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 0801162. ± Comparison against base commit 41155a7.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both. 
org.apache.uniffle.test.CoordinatorGrpcTest ‑ getShuffleAssignmentsTest
org.apache.uniffle.test.CoordinatorGrpcTest ‑ shuffleServerHeartbeatTest
org.apache.uniffle.test.ShuffleServerOnRandomPortTest ‑ startGrpcServerOnRandomPort
org.apache.uniffle.test.ShuffleServerOnRandomPortTest ‑ startStreamServerOnRandomPort

org.apache.uniffle.test.CoordinatorGrpcTest ‑ getShuffleAssignmentsTest{File}
org.apache.uniffle.test.CoordinatorGrpcTest ‑ shuffleServerHeartbeatTest{File}
org.apache.uniffle.test.ShuffleServerOnRandomPortTest ‑ startGrpcServerOnRandomPort{File}
org.apache.uniffle.test.ShuffleServerOnRandomPortTest ‑ startStreamServerOnRandomPort{File}

♻️ This comment has been updated with latest results.

@summaryzb
Copy link
Contributor Author

@jerqi @maobaolong PTAL

@summaryzb
Copy link
Contributor Author

gentle ping @LuciferYang

@LuciferYang LuciferYang changed the title [#2385] improvement(test): Make all tests in integration-common-test use random port [#2385] improvement(test): Make all tests in integration-common-test use random port Mar 12, 2025
LuciferYang
LuciferYang approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LuciferYang LuciferYang merged commit 87362fb into apache:master Mar 12, 2025
41 checks passed
@LuciferYang
Copy link
Contributor

Merged into master. Thanks @summaryzb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuciferYang LuciferYang LuciferYang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Subtask] All unit test in integration-common-test use random port
2 participants
@summaryzb @LuciferYang